Fix NTP test failures due to unsynchronized clock#19444
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Jul 7, 2025
Merged
Fix NTP test failures due to unsynchronized clock#19444yejianquan merged 1 commit intosonic-net:masterfrom
yejianquan merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@opcoder0 PR conflicts with 202505 branch |
Collaborator
|
hi @opcoder0 , do you mind to help pick this change to 202412? |
Collaborator
|
Having dependency on this PR: #18841. Currently, picking this up first. |
Merged
11 tasks
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#519 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
Contributor
|
PR conflicts with 202505 branch. Can you please check it. |
bingwang-ms
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Jul 30, 2025
This PR is to cherry-pick below PRs to 202503 branch - sonic-net/sonic-mgmt#17434 - sonic-net/sonic-mgmt#17629 - sonic-net/sonic-mgmt#18583 - sonic-net/sonic-mgmt#18627 - sonic-net/sonic-mgmt#18841 - sonic-net/sonic-mgmt#19444
Contributor
Author
Thank you @Verma-Anukul I have raised a PR manually - #19948 |
yejianquan
pushed a commit
that referenced
this pull request
Jul 31, 2025
yejianquan
added
Included in 202505 branch
and removed
Cherry Pick Conflict_202505
labels
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
Description of PR The PR contains fix for failed NTP testcases on Bookworm based PTF image. The NTPSec daemon on Bookworm has "tos minclock 4 minsane 3" configuration line which requires at least 4 clocks to be available before ntpstat reports synchronized status. Since we use local clock, the line is commented. Applicable only to docker-ptf images that are based on Bookworm. Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fix NTP test failures. How did you do it? See description How did you verify/test it? Manually in VS test testbed. Any platform specific information? No signed-off-by: jianquanye@microsoft.com
ashutosh-agrawal
pushed a commit
to ashutosh-agrawal/sonic-mgmt
that referenced
this pull request
Aug 14, 2025
Description of PR The PR contains fix for failed NTP testcases on Bookworm based PTF image. The NTPSec daemon on Bookworm has "tos minclock 4 minsane 3" configuration line which requires at least 4 clocks to be available before ntpstat reports synchronized status. Since we use local clock, the line is commented. Applicable only to docker-ptf images that are based on Bookworm. Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fix NTP test failures. How did you do it? See description How did you verify/test it? Manually in VS test testbed. Any platform specific information? No signed-off-by: jianquanye@microsoft.com
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
Description of PR The PR contains fix for failed NTP testcases on Bookworm based PTF image. The NTPSec daemon on Bookworm has "tos minclock 4 minsane 3" configuration line which requires at least 4 clocks to be available before ntpstat reports synchronized status. Since we use local clock, the line is commented. Applicable only to docker-ptf images that are based on Bookworm. Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fix NTP test failures. How did you do it? See description How did you verify/test it? Manually in VS test testbed. Any platform specific information? No signed-off-by: jianquanye@microsoft.com
opcoder0
added a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
Description of PR The PR contains fix for failed NTP testcases on Bookworm based PTF image. The NTPSec daemon on Bookworm has "tos minclock 4 minsane 3" configuration line which requires at least 4 clocks to be available before ntpstat reports synchronized status. Since we use local clock, the line is commented. Applicable only to docker-ptf images that are based on Bookworm. Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fix NTP test failures. How did you do it? See description How did you verify/test it? Manually in VS test testbed. Any platform specific information? No signed-off-by: jianquanye@microsoft.com Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Description of PR The PR contains fix for failed NTP testcases on Bookworm based PTF image. The NTPSec daemon on Bookworm has "tos minclock 4 minsane 3" configuration line which requires at least 4 clocks to be available before ntpstat reports synchronized status. Since we use local clock, the line is commented. Applicable only to docker-ptf images that are based on Bookworm. Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fix NTP test failures. How did you do it? See description How did you verify/test it? Manually in VS test testbed. Any platform specific information? No signed-off-by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Description of PR The PR contains fix for failed NTP testcases on Bookworm based PTF image. The NTPSec daemon on Bookworm has "tos minclock 4 minsane 3" configuration line which requires at least 4 clocks to be available before ntpstat reports synchronized status. Since we use local clock, the line is commented. Applicable only to docker-ptf images that are based on Bookworm. Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fix NTP test failures. How did you do it? See description How did you verify/test it? Manually in VS test testbed. Any platform specific information? No signed-off-by: jianquanye@microsoft.com Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Description of PR The PR contains fix for failed NTP testcases on Bookworm based PTF image. The NTPSec daemon on Bookworm has "tos minclock 4 minsane 3" configuration line which requires at least 4 clocks to be available before ntpstat reports synchronized status. Since we use local clock, the line is commented. Applicable only to docker-ptf images that are based on Bookworm. Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fix NTP test failures. How did you do it? See description How did you verify/test it? Manually in VS test testbed. Any platform specific information? No signed-off-by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
Description of PR The PR contains fix for failed NTP testcases on Bookworm based PTF image. The NTPSec daemon on Bookworm has "tos minclock 4 minsane 3" configuration line which requires at least 4 clocks to be available before ntpstat reports synchronized status. Since we use local clock, the line is commented. Applicable only to docker-ptf images that are based on Bookworm. Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fix NTP test failures. How did you do it? See description How did you verify/test it? Manually in VS test testbed. Any platform specific information? No signed-off-by: jianquanye@microsoft.com
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
Description of PR The PR contains fix for failed NTP testcases on Bookworm based PTF image. The NTPSec daemon on Bookworm has "tos minclock 4 minsane 3" configuration line which requires at least 4 clocks to be available before ntpstat reports synchronized status. Since we use local clock, the line is commented. Applicable only to docker-ptf images that are based on Bookworm. Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fix NTP test failures. How did you do it? See description How did you verify/test it? Manually in VS test testbed. Any platform specific information? No signed-off-by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
Description of PR The PR contains fix for failed NTP testcases on Bookworm based PTF image. The NTPSec daemon on Bookworm has "tos minclock 4 minsane 3" configuration line which requires at least 4 clocks to be available before ntpstat reports synchronized status. Since we use local clock, the line is commented. Applicable only to docker-ptf images that are based on Bookworm. Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fix NTP test failures. How did you do it? See description How did you verify/test it? Manually in VS test testbed. Any platform specific information? No signed-off-by: jianquanye@microsoft.com Signed-off-by: Yael Tzur <ytzur@nvidia.com>
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 3, 2026
Description of PR The PR contains fix for failed NTP testcases on Bookworm based PTF image. The NTPSec daemon on Bookworm has "tos minclock 4 minsane 3" configuration line which requires at least 4 clocks to be available before ntpstat reports synchronized status. Since we use local clock, the line is commented. Applicable only to docker-ptf images that are based on Bookworm. Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fix NTP test failures. How did you do it? See description How did you verify/test it? Manually in VS test testbed. Any platform specific information? No signed-off-by: jianquanye@microsoft.com
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
Description of PR The PR contains fix for failed NTP testcases on Bookworm based PTF image. The NTPSec daemon on Bookworm has "tos minclock 4 minsane 3" configuration line which requires at least 4 clocks to be available before ntpstat reports synchronized status. Since we use local clock, the line is commented. Applicable only to docker-ptf images that are based on Bookworm. Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fix NTP test failures. How did you do it? See description How did you verify/test it? Manually in VS test testbed. Any platform specific information? No signed-off-by: jianquanye@microsoft.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
The PR contains fix for failed NTP testcases on Bookworm based PTF image. The NTPSec daemon on Bookworm has "tos minclock 4 minsane 3" configuration line which requires at least 4 clocks to be available before
ntpstatreports synchronized status. Since we use local clock, the line is commented.Applicable only to
docker-ptfimages that are based on Bookworm.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix NTP test failures.
How did you do it?
See description
How did you verify/test it?
Manually in VS test testbed.
Any platform specific information?
No
Supported testbed topology if it's a new test case?
NA
Documentation
NA